SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.58k stars 271 forks source link

[Feature Request]: Progress Indicator - point size adjustments #8213

Closed PlutaKatarzyna closed 9 months ago

PlutaKatarzyna commented 10 months ago

Feature Request Description

UDEx components library

We need possibility to overwrite ui5-progress-indicator "point" size (the dot at the beginning and the end of progress bar).

Currently there is hardcoded value 0.25rem, but what we need is 0.375rem. In the following selector .ui5-progress-indicator-remaining-bar::before, .ui5-progress-indicator-remaining-bar::after there is hardcoded value of width and height.

Screenshot 2024-01-31 at 12 10 38

Proposed Solution

Include possibility to overwrite values of point size by adding ui5 variable.

Proposed Alternatives

No response

Organization

SAP

Additional Context

No response

Priority

Medium

Privacy Policy

petyabegovska commented 10 months ago

Hello @SAP/ui5-webcomponents-topic-p,

Please have a look at this feature request.

Best regards, Petya

jdichev commented 10 months ago

Hello @PlutaKatarzyna,

The value of 0.25rem is as per Horizon design specification. We'll raise query with our design colleagues and be back to you.

Best regards, Jordan

PlutaKatarzyna commented 10 months ago

Hello @jdichev Thank you. With our designs we increase the bar height, which automatically require bigger dot size. Link for the designs if you need it: https://www.figma.com/file/OFEfvhyXJvYJ6MQZ30699m/v2.0-Brand-Digital-Design-System?type=design&node-id=5874%3A7&mode=design&t=6eiov43ejqJWF7Ay-1

jdichev commented 10 months ago

Hello @PlutaKatarzyna, Thanks. We'll set aside some time to work on this in coming takt. Internal reference BGSOFUIPIRIN-6454.

plamenivanov91 commented 9 months ago

Hello @PlutaKatarzyna ,

I merged this pull request where a new CSS part is introduced.

It's shown how to achieve your target design in the commit message.

Regards, Plamen Ivanov