search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.52k stars 263 forks source link

[Feature Request]: Loading property behaviour in appropriate in ui5-combobox and ui5-multi-combobox #8232

Open sanketzad opened 8 months ago

sanketzad commented 8 months ago

Feature Request Description

Impacted components: ui5-combobox and ui5-multi-combobox

Loading property behaviour is bit confusing, when loading property is true, what does this signify

  1. loading only shows up if the list is empty(?)
  2. loading shows up at the end of the list (“scroll-to-load”)
  3. loading indicator is shown on a semi-transparent black background I guess, it is rather the 3rd entry, it's randomly shows loading on top of the dropdown items.

image

The busy indicator should not occupy the whole available height of the responsive popover over the drop-down items in the background, like in the above image. Rather it should much smaller and independent of the height of the responsive popover height and width.

Proposed Solution

As part of the solution, it would be more accurate if the loading or busy status should be shown in much smaller size without, depending on the size of the responsive popover. This is exact implementation in SAP UI5 control, where the loading/busy state would look like below:

image

Proposed Alternatives

No response

Organization

Ariba

Additional Context

No response

Priority

None

Privacy Policy

yanaminkova commented 8 months ago

Hello @SAP/ui5-webcomponents-topic-rl ,

Please have a look at this feature request about the loading indicator inside the ui5-combobox

Thanks and Best regards, Yana

elenastoyanovaa commented 8 months ago

Hello @sanketzad ,

Can you please provide a sample how are you using the loading feature and when exactly (on which event do you update it)? We need to evaluate your use case in order to determine how to proceed with this - as a bug or as a feature request.

Please adjust the following example: https://stackblitz.com/edit/js-vsrpnb?file=index.js,index.html

Kind Regards, Elena

sanketzad commented 8 months ago

Hi @elenastoyanovaa ,

I believe this won't be a bug; rather, it would be a feature request, because Loading property is to signify that list items are getting loaded. It would not make sense to show all the list items in the background with busy indicator on top of the same. So to keep uniformity, when a component is loading then it would be good if we can make a similar experience as that of SAP UI5 controls, where the responsive popover will be lot smaller as displayed in the issue description above.

I have added ComboBox example in here with loading as a property.

With regards, Sanket Zad

elenastoyanovaa commented 8 months ago

Hello colleauges,

The case is for the loading property of the comboboxes. When loading: true is set, the busy indicator is shown on top of the list, which may not be the proper visualisation of a loading combobox. Please check the images and provided sample.

The desired visualisation is the same as in UI5. For example check the lazy loading sample https://sapui5.hana.ondemand.com/#/entity/sap.m.ComboBox/sample/sap.m.sample.ComboBoxLazyLoading/

I saw that there is already a FR for support for lazy loading ( https://github.com/SAP/ui5-webcomponents/issues/4483 ) which is partially related to this one, but this is more specifically to the already existing loading property.

Kind Regards, Elena

hristop commented 6 months ago

Internal BLI created: BGSOFUIRILA-3826