[Feature Request]: Allow Carousel component navigation styles to be updated

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.

https://sap.github.io/ui5-webcomponents/

Apache License 2.0

1.51k stars 260 forks source link

[Feature Request]: Allow Carousel component navigation styles to be updated #8313

Closed MaksymPakhomov closed 6 months ago

MaksymPakhomov commented 7 months ago

Feature Request Description

At the moment, the navigation section of the component is not available for overriding styles. When reusing a component, it is not possible to apply an updated design for control buttons, make the disabled state, etc.

Proposed Solution

Expand the code for the component by adding a part attribute for the general navigation container and the buttons. There are two options for buttons: the first for normal state and the second for hidden.

Proposed Alternatives

No response

Organization

SAP

Additional Context

No response

Priority

Medium

Privacy Policy

[X] I’m not disclosing any internal or sensitive information.

ilhan007 commented 7 months ago

Hello @MaksymPakhomov could you be more specific on the re-styling that you would like to apply, maybe screenshot comparison, how it's now and what would you like to achieve.

Hello @SAP/ui5-webcomponents-topic-rd this request goes to you.

The requested parts are the following;

Discuss if the places for new "parts" are reasonable and the associated elements of the Carousel are likely to remain in future. Meanwhile I requested more details from the author to understand what's the target design, that could not be achieved with the current Carousel implementation.

MaksymPakhomov commented 7 months ago

Hello @ilhan007, the current design (the button on the left is hidden since this is the first slide):

and we would like to update the navigation part: default and hover button states (buttons always are visible)- and the new additional position for the buttons:

MaksymPakhomov commented 7 months ago

I would like to add this block also to the list of blocks for which styles need to be updated (I need to hide it from the page, now even if it is hidden it takes up space). Thank you

MaksymPakhomov commented 6 months ago

Hello, @ilhan007, I found a solution that allows us to implement the required updates to the carousel component without the changes indicated in the comments above, sorry for the inconvenience.

ilhan007 commented 6 months ago

Closing the issue as not needed any more.