search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.55k stars 266 forks source link

Timeline: subTitle text are truncated without ellipsis #8387

Closed pankajpandey01 closed 8 months ago

pankajpandey01 commented 8 months ago

Bug Description

In long subTitle case, subTitle text are truncated without ellipsis and there is no title attribute to show complete text to user on mouseover. In this case right border of timeline item is also removed.

Affected Component

Timeline

Expected Behaviour

In long subTitle case, 1) subTitle should support truncation with ellipsis. 2) There should be title on truncated text to show complete text. 3) Right border of timelineItem should not be removed.

Isolated Example

No response

Steps to Reproduce

  1. Go to https://sap.github.io/ui5-webcomponents/playground/?path=/docs/fiori-timeline-timeline-item--timeline-item-overview
  2. Enter long subTitle text.

Log Output, Stack Trace or Screenshots

Screenshot 2024-03-01 at 12 58 17 PM

Priority

High

UI5 Web Components Version

1.22

Browser

Chrome, Edge, Firefox, Safari

Operating System

No response

Additional Context

Please down port fix to "1.19.1" No response

Organization

SuccessFactors

Declaration

nnaydenow commented 8 months ago

Hi @sap/ui5-webcomponents-topic-b,

Could you please check the issue?

hinzzx commented 8 months ago

Hi @pankajpandey01 ,

I've observed and tested the reported issue, and to me it seems like you would need a way of providing a custom tooltip/title, as well as setting a width to the subtitle text or the ui5-timeline-item itself, in order to get an ellipsis truncation based on your usecase.

If thats the case, I will move the incident into the feature requests section, and would have to be discussed internally with the team. Could you please provide more details about your usecases, so that we could have a better understanding of the desired features ?

Best Regards, Stoyan

pankajpandey01 commented 8 months ago

Hi @hinzzx Our use case is that if the subTitle is longer that Timeline width, it should truncate with ellipsis and when it is truncated user should have ability to view full text by any means preferably title. Currently it truncates abruptly and also impact right border of timeline as we can see in attached screenshot. I think current behavior should be considered as defect.

hinzzx commented 8 months ago

Hi @pankajpandey01 ,

Thank you for the input!

Could you please separate this issue into two different incidents ?

One as a feature request, and the other one as bug report, as this would be the better way of tracking the progress between the two.

Thank you in advance!

Best Regards, Stoyan

hinzzx commented 8 months ago

Hey @pankajpandey01,

I've separated this report into two different incidents. You can track them here:

Best Regards, Stoyan

DMihaylova commented 7 months ago

Hi @pankajpandey01,

After the fix we made in order the text to be fully visible (https://github.com/SAP/ui5-webcomponents/pull/8462), I suppose the title request is no longer valid, right?