search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.47k stars 254 forks source link

[MultiComboBox]:Count is not displaying for selected items #8493

Closed roshnijalan97new closed 1 day ago

roshnijalan97new commented 3 months ago

Bug Description

when the user selects multiple items from the drop down and the click outside the combo box. It displays the count.

Screenshot 2024-03-21 at 2 10 36 PM

If the user again click on the number and unselects some items

Screenshot 2024-03-21 at 2 12 23 PM

Then it is observed that the count is not displayed.

Screenshot 2024-03-21 at 2 12 23 PM

Affected Component

MultiComboBox

Expected Behaviour

Count should always be displayed for the selected items in the combo box.

Isolated Example

No response

Steps to Reproduce

  1. Go to https://codesandbox.io/p/sandbox/still-snow-65xrvf?file=%2Fsrc%2FApp.tsx
  2. when the user selects multiple items from the drop down and the click outside the combo box. It displays the count.
  3. If the user again click on the number and unselects some items
  4. Then it is observed that the count is not displayed.

Log Output, Stack Trace or Screenshots

No response

Priority

Medium

UI5 Web Components Version

1.9.3

Browser

Chrome

Operating System

Mac Os

Additional Context

No response

Organization

No response

Declaration

petyabegovska commented 3 months ago

Hi @roshnijalan97new,

Clicking outside the multi combo box, always displays the count, I tried with selection and deselection. Can you give more details how to reproduce it? Do you expect the count to be displayed before clicking outside of the multi combo box?

Can you reproduce it in the latest version: latest sample with multi combo box?

Best regards, Petya

roshnijalan97new commented 3 months ago

Hi @petyabegovska, The steps are as follows: 1) select as many elements as you can, ex: selected 7 elements

Screenshot 2024-04-01 at 11 24 01 AM

2) Click outside the combo box. it should the no of elements as expected.

Screenshot 2024-04-01 at 11 24 13 AM

3)Now, click on 6more. the drop down will be show like below image, showing only 7 items which we selected.

Screenshot 2024-04-01 at 11 24 25 AM

4) Now, deselect as few items from the list.

Screenshot 2024-04-01 at 11 24 32 AM

5) Click outside the combo box. The display of items is not as expected

Screenshot 2024-04-01 at 11 24 37 AM
dobrinyonkov commented 3 months ago

Hello @SAP/ui5-webcomponents-topic-rl,

this issue is reproducible in the following snippet in the playground.

  1. Select 4 items
  2. Click outside the dropdown
  3. Click exactly on the 3 more link/label
  4. Deselect an item
  5. Click outside the dropdown

Result "N more" label is not shown anymore

Could you please have a look?

Thanks, Dobrin

ivoplashkov commented 1 month ago

Hello,

The issue is fixed in version 2.0 with the following change - #8484. However we need to prepare a separate downport for 1.24 as the codebase differs a lot by the introduction of the popover API.

Regards, Ivaylo