search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.5k stars 258 forks source link

[DynamicSideContent]: aria-label for the side panel is meaningless and not customizable and missing aria-label for the main conent #8612

Open yzy415 opened 5 months ago

yzy415 commented 5 months ago

Bug Description

As shown below, the aria-label for the side panel is "Side Content" which is too generic and not customizable. We should support accepting the consumer-defined aria-lable for the side panel.

Besides, the aria-label for the main content is missed.

image

Affected Component

DynamicSideContent

Expected Behaviour

aria-label for the side panel should be customizable and we should also give the main content a customizable aria-label.

Isolated Example

No response

Steps to Reproduce

  1. go to ui5 DynamicSideContent documentation
  2. inspect the side content and main content

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

1.26.1

Browser

Chrome, Edge, Firefox, Safari

Operating System

No response

Additional Context

No response

Organization

SAP SF

Declaration

dobrinyonkov commented 5 months ago

Hello @SAP/ui5-webcomponents-topic-b,

There is a feature request to provide an API to set custom labels on the side content area/contianer. Also, the main area/container seems to lack accessibility attributes (like role and aria-label). You can inspect the sample in the playground: https://sap.github.io/ui5-webcomponents/nightly/components/fiori/DynamicSideContent Could you please have a look?

Kind Regards, Dobrin

NHristov-sap commented 4 months ago

Hi @yzy415 ,

The request is now internally logged as FIORITECHE1-8187, and we'll promptly notify you once it's been addressed. Thanks & Regards,

Nikolay Hristov