SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.47k stars 254 forks source link

[Feature Request]: ui5-shellbar profile button aria-label #8708

Open JarrettChan opened 2 months ago

JarrettChan commented 2 months ago

Feature Request Description

Provide an API for setting aria-label of the ui5-shellbar profile button.

Similar to this request for the ui5-shellbar menu button https://github.com/SAP/ui5-webcomponents/issues/6826

Proposed Solution

Add support for accessibilityNames.profileButtonName to set the profile button aria-label

Proposed Alternatives

No response

Organization

SuccessFactors

Additional Context

We have an incident where the screenreader's button finder used the aria-label of the Avatar component inside of the profile button as "Avatar, collapsed subMenu". accessibleName in Avatar can not override the aria-label with a falsey value.

Priority

Low

Privacy Policy

niyap commented 2 months ago

Hello @SAP/ui5-webcomponents-topic-p,

Could you please take a look of this feature request?

Thank you in advance!

Kind Regards, Niya

JarrettChan commented 2 months ago

As a workaround I will set the accessible-name of my [ui5-avatar][slot="profile"] component.

dobrinyonkov commented 2 months ago

Internal reference: BGSOFUIPIRIN-6547