SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.51k stars 262 forks source link

[SF][a11y][ui5-popover]: ui5 popover component inside shellbar role should be menu with menu items #8821

Closed lormanlau1 closed 3 months ago

lormanlau1 commented 5 months ago

Bug Description

Using the popover component inside the shellbar appears to look more like a menu/menuitem but is assigned the role of dialog. https://www.w3.org/WAI/ARIA/apg/patterns/menu-button/examples/menu-button-actions/

Screenshot 2024-04-22 at 2 56 44 PM

Affected Component

ui5-popover & ui5-shellbar

Expected Behaviour

The ask is change role of dialog to role of menu and make the list items inside role of menuitem. https://www.w3.org/WAI/ARIA/apg/patterns/menu-button/examples/menu-button-actions/

Isolated Example

https://sap.github.io/ui5-webcomponents/components/fiori/ShellBar/#profile-area

Steps to Reproduce

  1. navigate to https://sap.github.io/ui5-webcomponents/components/fiori/ShellBar/#profile-area
  2. click on the profile button to show popover
  3. observe that the popover has the role dialog

Log Output, Stack Trace or Screenshots

No response

Priority

Medium

UI5 Web Components Version

1.24.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

SAP SuccessFactors

Declaration

NHristov-sap commented 5 months ago

Hello @ui5-webcomponents-topic-p,

I am forwarding this issue to you, please check the reported issue.

Best Regards, Nikolay Hristov UI5 WebC Dispatcher