SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.47k stars 254 forks source link

[ui5-cell ui5-button]: A disabled button as last element in the tab chain will prevent focus to first element in the tab chain #8852

Closed f16r closed 1 month ago

f16r commented 2 months ago

Bug Description

A disabled button inside a table cell as last element in the tab chain will prevent to move focus to first element in the tab chain.

Affected Component

ui5-cell ui5-button

Expected Behaviour

Moving focus to the first element in the tab chain should be possible without marking a disabled button explicitly with tabIndex -1

Isolated Example

https://codesandbox.io/p/sandbox/ui5-webcomponents-playground-forked-q9dqxj?file=%2Findex.html

Steps to Reproduce

  1. Go to isolated example
  2. Click on last row to focus the row
  3. Click tab -> tabbing is stuck
  4. Workaround: Set tabIndex on button explicitly to -1. Tabbing is not stuck anymore (expected behaviour)

Log Output, Stack Trace or Screenshots

No response

Priority

Medium

UI5 Web Components Version

1.24.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

CBC

Declaration

NHristov-sap commented 2 months ago

Hello @ui5-webcomponents-topic-b,

I am forwarding this issue to you, because the issue is reproducible and the solution proposed by the reporter seems to be valid. Please check and fix.

Best Regards, Nikolay Hristov UI5 WebComponents Dispatcher