search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.52k stars 263 forks source link

[ui5-shellbar]: shellbar accessible name #8930

Closed JarrettChan closed 2 months ago

JarrettChan commented 4 months ago

Bug Description

A new customer is complaining that the accessible name "Shell Bar" does not meet 508 accessibility requirements.

"We understand that the "Shell Bar" is the term for the SAP designed header. However, it doesn't meet 508 requirements and it doesn't provide any description for people using Accessibility apps. Is it possible that it will be changed to meet Accessibility requirements? "

Direct link to ticket in shared offline channel.

Affected Component

ui5-shellbar

Expected Behaviour

From discussing with our A11Y, this name is a subjective topic. My guess is that we would need a hook to specify the aria label and provide the user a way to specify the label. Please help determine the direction.

Isolated Example

No response

Steps to Reproduce

No response

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

1.17.4

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

SuccessFactors

Declaration

GerganaKremenska commented 4 months ago

Hello @SAP/ui5-webcomponents-topic-p,

Please review the aria-label of Shell Bar and review if it necessary to add accessible-name.

Best Regards, Gergana

petyabegovska commented 4 months ago

Customer is considering this one of their go-live blockers by ~May 31st.

yanaminkova commented 4 months ago

Hello @JarrettChan,

We are currently consulting with accessibility experts. Could you please specify which part of the standard is not being met by our current implementation? This information will help us provide a clearer explanation to the experts.

Thanks and Kind regards, Yana

github-actions[bot] commented 3 months ago

Hello, everyone! The issue has been inactive for 21 days. If there are still questions or comments, please feel free to continue the discussion. Inactive issues will be closed after 7 days!

github-actions[bot] commented 3 months ago

Hello, everyone! The issue has been inactive for 21 days. If there are still questions or comments, please feel free to continue the discussion. Inactive issues will be closed after 7 days!

JarrettChan commented 2 months ago

The customer did not cite a specific standard. The customer disagrees that the accessible name "Shell Bar" is meaningful, which I guess is an inappropriate label/name.

github-actions[bot] commented 2 months ago

Hello, everyone! The issue has been inactive for 21 days. If there are still questions or comments, please feel free to continue the discussion. Inactive issues will be closed after 7 days!

yanaminkova commented 2 months ago

Hello @JarrettChan,

After consulting with the accessibility experts, we have confirmed that the ui5-shellbar aligns with both the design system and screen reader specifications. The default term "Shell bar" also adheres to the naming conventions outlined in the SAP Fiori Design Guidelines. According to feedback from the accessibility experts, altering this default term for users who are blind could result in a "semantic decoupling" in meaning.

For these reasons, we recommend not making any changes.

Thanks and Kind regards, Yana