SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.51k stars 263 forks source link

[Illustrative Message Component]: description (body text) using wrong color parameter #8984

Closed ShirSAP closed 4 months ago

ShirSAP commented 4 months ago

Bug Description

Today the description (body text) is using "--sapContent_LabelColor" color parameter.

Affected Component

https://sap.github.io/ui5-webcomponents-react/?path=/docs/user-feedback-illustratedmessage--docs

Expected Behaviour

we should use "color: --sap_TextColor;" instead. This is specified in the following wiki: https://wiki.one.int.sap/wiki/pages/viewpage.action?pageId=3139378128

Isolated Example

No response

Steps to Reproduce

1. 2. 3. ...

Log Output, Stack Trace or Screenshots

No response

Priority

Low

UI5 Web Components Version

1.18.0

Browser

Chrome

Operating System

OS

Additional Context

No response

Organization

No response

Declaration

GerganaKremenska commented 4 months ago

Hello @ui5-webcomponents-topic-p I am forwarding this issue to you, because there is a diviation from the parameter given in the VD specifcation and the one set to the description text of the illustrated message.

Best Regards, Gergana

ilhan007 commented 4 months ago

Hello @ShirSAP the issue has been fixed and will be available with: 1.24.X - start of June 2.0.0-rc.X - start of June

The fix can be seen on the nightly deployment https://sap.github.io/ui5-webcomponents/nightly/components/fiori/IllustratedMessage/#illustratedmessage-in-dialog