search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.52k stars 263 forks source link

Wizard: onStepChange is called to early for large wizard content #9083

Closed ChewbaccaCookie closed 2 weeks ago

ChewbaccaCookie commented 4 months ago

Describe the bug

If the wizard content gets to large in a step, the onStepChange callback is executed to early. This is a problem especially if you use the SIngleStep content layout, because the component will switch to the next step, before the user can scroll to the bottom.

Isolated Example

https://stackblitz.com/edit/github-rn2kg4?file=src%2FApp.tsx

Reproduction steps

  1. Create a big content in a wizard step
  2. Set the contentLayout to singleStep
  3. Scroll down to the bottom

Expected Behaviour

That the user can scroll to the bottom, without switching the step. Especially in the SingleStep content layout.

Screenshots or Videos

https://github.com/SAP/ui5-webcomponents-react/assets/15861250/df3a1428-0b92-4951-adde-2cd37defb33a

UI5 Web Components for React Version

1.24.3

UI5 Web Components Version

1.28.0

Browser

Chrome, Edge, Firefox, Safari

Operating System

No response

Additional Context

No response

Relevant log output

No response

Organization

SAP T&I

Declaration

MarcusNotheis commented 4 months ago

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

plamenivanov91 commented 4 months ago

Hello @SAP/ui5-webcomponents-topic-rl,

The Wizard goes to its next page when scrolled to bottom.

I couldn't reproduce it locally, but it's easily reproducible with the provided snippet which uses 1.24.

Is this expected behavior ?

Regards, Plamen Ivanov

ksblklu02 commented 1 month ago

Hi @plamenivanov91 Do we have any updates on this issue?