search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.51k stars 263 forks source link

Shellbar: The logo should not be should as a button if there are no actions are to be performed on it #9135

Closed pppwr7 closed 1 month ago

pppwr7 commented 4 months ago

Is your feature request related to a problem?

Hi Colleagues, We have a requirement that the SAP logo is to be shown in the shellbar. However, there would be not action performed on clicking on it. So, it should be shown as just an image which is non-interactable.

Describe the solution you'd like

it should be shown as just an image which is non-interactable.

Describe alternatives you've considered

No response

Additional Context

No response

Organization

No response

Declaration

Lukas742 commented 4 months ago

Hi @pppwr7

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

Hi colleagues,

although it's possible to set the role of the logo to something else than "button" (via accessibilityRoles), there's currently no way of removing it from the tab-chain or replacing/removing interactive styles like :focus or :hover.

niyap commented 4 months ago

Hello @SAP/ui5-webcomponents-topic-p,

Could you please check and analyse that feature request?

Thank you in advance!

Kind Regards, Niya

pppwr7 commented 3 months ago

Hi Colleagues, could you please let me know if there are any updates on this issue? Will it be taken up as feature request?

dobrinyonkov commented 3 months ago

Hi @pppwr7,

The ui5-shellbar is being redesigned according to a new UX and VD specification. The logo will no longer be interactive on its own; instead, it will be combined with the primary-title into a single interactive element. Additionally, a new "lean" mode will be introduced, where this combined area will not be clickable. In this lean mode, the shellbar will have fewer features:

image

Essentially, the "lean" mode is shown in the second shellbar of the image above. Let us know if that would meet your requirements. If not, we kindly ask you to provide more details about your use case.

Why do you need the Logo as static (non-clickable)? Do you offer other means to navigate back to your app's Home page? Perhaps, you have a page bar above the shellbar?

We will share those details with the design owners.

Thanks and Regards, Dobrin

github-actions[bot] commented 2 months ago

Hello, everyone! The issue has been inactive for 21 days. If there are still questions or comments, please feel free to continue the discussion. Inactive issues will be closed after 7 days!

github-actions[bot] commented 1 month ago

Hello, everyone! The issue has been inactive for 28 days, so I am closing the issue.

pppwr7 commented 3 days ago

Hi Colleagues,

Apologies for the delayed reply.

Please let me know when the lean mode of the shell bar would be available to use.

As per our requirement, we don't have a home page. So, we don't need the logo to be clickable. We show a side navigation panel, listing a range of apps available. This panel could be opened using the startButton of shellbar. We also have other action buttons in our shell bar. These are added using ShellBarItem control.

Please let me know if any further details is needed from our end.

Regards, Priya