search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.52k stars 263 forks source link

Combobox, multicombobox, select: user is unable to filter on both the text and additional text prop fields #9142

Closed pppwr7 closed 1 month ago

pppwr7 commented 3 months ago

Describe the bug

As per customer requirement, whenever user enters a letter in combobox input , he wants to the filtered suggestion dropdown shown to consider additional text data too. currently, the filtering happens only on id prop data.

Isolated Example

https://stackblitz.com/edit/github-6zne66-fk2sbi?file=src%2FApp.tsx,package.json

Reproduction steps

  1. open the example above
  2. in the dropdown input field, type 1
  3. no suggestions are shown since 1 is not present as data in any of the id property. However, it is present as a additional text prop data.

Expected Behaviour

additional text data should also be considered for filtering

Screenshots or Videos

No response

UI5 Web Components for React Version

latest

UI5 Web Components Version

latest

Browser

Chrome

Operating System

No response

Additional Context

No response

Relevant log output

No response

Organization

No response

Declaration

Lukas742 commented 3 months ago

Hi @pppwr7

your example doesn't compile, because you used incompatible versions of @ui5/webcomponents and @ui5/webcomponents-react. I updated it to use the latest version of both packages: https://stackblitz.com/edit/github-6zne66-vasao7?file=src%2FApp.tsx,package.json

Since all three components are developed by the UI5 Web Components team, I'll forward this feature request to their repo.

Hi colleagues, could you please take over?

niyap commented 3 months ago

Hello @SAP/ui5-webcomponents-topic-rl,

Could you please check that feature request?

Thank you in advance!

Kind Regards, Niya

ilhan007 commented 3 months ago

Moving to RL board (it was in RD by mistake)

hristop commented 2 months ago

Hi @pppwr7 ,

After discussions with our design team, this feature request should go through the inner source process. Can you please create BLI to Central Design and put the number of the E1 here for reference?

Best Regards, Hristo

github-actions[bot] commented 1 month ago

Hello, everyone! The issue has been inactive for 21 days. If there are still questions or comments, please feel free to continue the discussion. Inactive issues will be closed after 7 days!

github-actions[bot] commented 1 month ago

Hello, everyone! The issue has been inactive for 28 days, so I am closing the issue.