search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.52k stars 263 forks source link

[ui5-multi-combobox] open properly is badly named #9169

Closed amaillard-sap closed 2 months ago

amaillard-sap commented 3 months ago

Bug Description

The 'open' property is named '_open' in the DOM

Affected Component

MultiCombobox

Expected Behaviour

The 'open' property should be named 'open'

Isolated Example

Can be observed on the documentation (https://sap.github.io/ui5-webcomponents/playground/?path=/docs/main-multi-combo-box--multi-combo-box-overview)

Steps to Reproduce

  1. Create a MultiCombobox
  2. Open it
  3. Observe the element properties in the DOM

Log Output, Stack Trace or Screenshots

image

Priority

Medium

UI5 Web Components Version

1.24.4

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

SBPA

Declaration

nnaydenow commented 3 months ago

Hi @amaillard-sap,

Property open is meant to be readonly which means that it doesn't have respective attribute. Readonly properties are meant to be used only in programatic way for example: mcb.open. Seems like the documentation should be adjusted to display readonly properties as such.

nnaydenow commented 2 months ago

Fixed with: https://github.com/SAP/ui5-webcomponents/pull/9278