[SegmentedButtonItem (2.0.0-rc.5)]: item is missing margin between icon and text - Githubissues

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.

https://sap.github.io/ui5-webcomponents/

Apache License 2.0

1.51k stars 263 forks source link

[SegmentedButtonItem (2.0.0-rc.5)]: item is missing margin between icon and text #9172

Closed Lukas742 closed 3 months ago

Lukas742 commented 3 months ago

Bug Description

This is a regression in v2.0.0-rc.5. The icon inside a SegmentedButtonItem doesn't include a margin anymore:

v1.24.4: https://stackblitz.com/edit/github-9rdfm1?file=index.html,main.js,package.json

v2.0.0-rc.5: https://stackblitz.com/edit/github-9rdfm1-f76m3t?file=index.html,main.js,package.json

Affected Component

SegmentedButtonItem

Expected Behaviour

No response

Isolated Example

https://stackblitz.com/edit/github-9rdfm1-f76m3t?file=index.html,main.js,package.json

Steps to Reproduce

Go to StackBlitz
See that the icon is too close to the text of the button

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

v2.0.0-rc.5

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

UI5WCR

Declaration

[X] I’m not disclosing any internal or sensitive information.

ilhan007 commented 3 months ago

Hello @SAP/ui5-webcomponents-topic-b I think it's a highly visible visual degradation that needs to be fixed