search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.51k stars 263 forks source link

[BarcodeScannerDialog (v2.0.0-rc.5)]: `close` event is not called and `open` not removed when closing via ESC #9177

Closed Lukas742 closed 3 months ago

Lukas742 commented 3 months ago

Bug Description

This only happens with v2.0.0-rc.5. When closing the BarcodeScannerDialog via ESC press, the close event is not called and also the open attribute is not removed leading to an inaccessible state of the popover.

Affected Component

BarcodeScannerDialog

Expected Behaviour

No response

Isolated Example

https://stackblitz.com/edit/github-hkau5h?file=index.html,main.js,package.json

Steps to Reproduce

  1. Go to StackBlitz
  2. Open the browser's dev tools console
  3. Open the dialog by pressing the button
  4. Close the dialog by pressing the "Close" button --> close event is fired, open attribute removed
  5. Open the dialog again
  6. Close the dialog by pressing the "Escape" key --> close event isn't fired, open attribute persists

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

UI5WCR

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

ilhan007 commented 3 months ago

Hello @SAP/ui5-webcomponents-topic-p it's a high importance issue related to the 2.0 refactoring