SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.46k stars 253 forks source link

[SF_ACC][ui5-date-picker]: AXE errors about the ui5-date-picker dialog #9189

Open ksblklu02 opened 2 weeks ago

ksblklu02 commented 2 weeks ago

Bug Description

AXE tool has identified some ARIA issues and accessible name on the calendar dialog

  1. Month select dialog & date select dialog: ARIA dialog and alertdialog node should has an accessible name
image image
  1. Elements with an ARIA role that require child roles contain them

    image
  2. Different "open picker" button should have unique aria-label, associated with ui5-date-picker accessibleName

image

Affected Component

ui5-date-picker

Expected Behaviour

  1. There should not be AXE Errors
  2. "Open picker" button should have aria-label associated with date picker accessibleName

Isolated Example

https://stackblitz.com/edit/github-pzxshp

Steps to Reproduce

  1. Go to https://stackblitz.com/edit/github-pzxshp
  2. Open date picker dialog
  3. Run AXE Devtools
  4. See there are some issues reported

Log Output, Stack Trace or Screenshots

No response

Priority

Medium

UI5 Web Components Version

1.24.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

SAP SuccessFactors

Declaration

unazko commented 2 weeks ago

Hello @SAP/ui5-webcomponents-topic-b,

There are AXE tool reports for the ui5-date-picker component.

Additionally there are already the following PRs that would fix some of the issues:

Best regards, Boyan

unazko commented 1 week ago

Hello @ksblklu02,

Transport for issue 1 into 1.24 is done: https://github.com/SAP/ui5-webcomponents/pull/9221

Best regards, Boyan