search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.51k stars 263 forks source link

[DynamicPage (v2.0.0-rc.6)]: outline recommended `font-size` of `heading` in docs #9253

Closed Lukas742 closed 1 month ago

Lukas742 commented 3 months ago

At the moment I don't think it's described clearly enough how to adjust the font-size of the heading to the recommended values. The relevant CSS variables can be found in the code examples, but it's probably worth mentioning them more clearly in the docs. E.g. in the description of the heading slot.

CSS Vars:

hinzzx commented 3 months ago

Hey colleagues,

@SAP/ui5-webcomponents-topic-p, could you please take a look at this recommendation from our colleague, about enhancing the documentation of our DynamicPage component ?

Kind Regards, Stoyan

dobrinyonkov commented 3 months ago

Internal Reference: BGSOFUIPIRIN-6587

Lukas742 commented 1 month ago

Hi, I've noticed that the information is now exposed in the documentation: https://sap.github.io/ui5-webcomponents/components/fiori/DynamicPageTitle/#heading

So, this issue can probably be closed, right?

dobrinyonkov commented 1 month ago

Hi @Lukas742 , that's correct, thanks for reminding!