fix(ui5-table): remove circular dependency from table and row

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.

https://sap.github.io/ui5-webcomponents/

Apache License 2.0

1.46k stars 253 forks source link

fix(ui5-table): remove circular dependency from table and row #9261

Closed DonkeyCo closed 1 week ago

DonkeyCo commented 1 week ago

remove cyclic import in TableRowBase of Table.ts
add TableUtils.ts, which adds duck-typed instanceof checks for safe imports

Fixes: #9247

DonkeyCo commented 1 week ago

@aborjinik We can certainly try that. It would be different to how other components would handle this, but I think the Table structure and its components is anyways pretty different to the existing components.

I'll try to implement the change in this PR: https://github.com/SAP/ui5-webcomponents/pull/9205