search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.46k stars 253 forks source link

chore: remove eslint dependency from base package #9263

Closed dimovpetar closed 1 week ago

dimovpetar commented 1 week ago

ESLint is provided by the tools package

pskelin commented 1 week ago

Nayden is right, even though it is coming from the tools package, it might be removed and will break here. I think tools like pnpm will also warn you about indirect usage of dependencies so it is best to keep it.

dimovpetar commented 1 week ago

In packages like main, fiori and etc we are consuming package-script from tools package. Unlike them the base package has it's own package-script and in IMO we should keep eslint here. Also do we benefit somehow if we remove it?

While trying to understand more about the linting of the framework I was confused why this package is also listed in the base's dependencies. I thought that removing it would spare unnecessary double maintenance in the future, but now I understand that is needed. Thanks for the explanation