SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.46k stars 253 forks source link

【SF】【A11y】[SplitButton]: [Missing aria-label for arrow button in splitButton] #9295

Open tandan0813 opened 3 days ago

tandan0813 commented 3 days ago

Describe the bug

When used SplitButton, there will have an A11y issue shows missing accessbile text in arrow icon button. image

Isolated Example

https://stackblitz.com/edit/github-nvtvkb?file=src%2FApp.tsx

Reproduction steps

Refer isolated example.

Expected Behaviour

Add aria-label "more" for arrow button in splitButton

Screenshots or Videos

No response

UI5 Web Components for React Version

1.29.2

UI5 Web Components Version

1.24.4

Browser

Chrome

Operating System

No response

Additional Context

No response

Relevant log output

No response

Organization

No response

Declaration

Lukas742 commented 3 days ago

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

kineticjs commented 3 days ago

Hello @SAP/ui5-webcomponents-topic-b,

The issue is about missing aria lable for the menu button of the ui5-split-button. In the screenreader spec I found the following: "