search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.47k stars 254 forks source link

[input like]: remove cloneNode from valueStateMessage slot #9347

Open nnaydenow opened 4 days ago

nnaydenow commented 4 days ago

Bug Description

Before, the valueStateMessage slot content had to be cloned because the content was rendered outside of the component in the ui5-popover inside ui5-static-area. With the integration of Popover API, the ui5-popover is placed inside the shadow root of the component, eliminating the need for the clone.

Affected Component

ui5-combobox, ui5-file-uploader, ui5-multi-combobox, ui5-select, ui5-textarea

Expected Behaviour

Instead of node cloning use <slot name="valueStateMessage"></slot>

nnaydenow commented 4 days ago

Hello @SAP/ui5-webcomponents-topic-b, @SAP/ui5-webcomponents-topic-rl, @SAP/ui5-webcomponents-topic-p, @SAP/ui5-webcomponents-topic-rd,

Please take a look at this enhancement.

dobrinyonkov commented 47 minutes ago

Internal Reference: BGSOFUIPIRIN-6611