search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.52k stars 263 forks source link

ui5-button, ui5-toast: remove "bdi" HTML elements, which surround <slot>, as it doesn't work #9409

Closed TeodorTaushanov closed 2 months ago

TeodorTaushanov commented 3 months ago

Bug Description

<bdi><slot></slot></bdi> doesn't work

bdi tags are already removed for ui5-text, ui5-tag, ui5-label components https://github.com/SAP/ui5-webcomponents/pull/9363

Affected Component

No response

Expected Behaviour

No response

Isolated Example

No response

Steps to Reproduce

No response

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

2.0

Browser

Chrome, Edge, Firefox, Safari

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

TeodorTaushanov commented 3 months ago

Hi @SAP/ui5-webcomponents-topic-rl, @SAP/ui5-webcomponents-topic-b, can you check if this should be done in your components?

tsanislavgatev commented 2 months ago

As discussed, this should be kept in the ui5-button component.

TeodorTaushanov commented 2 months ago

In fact, it works on FF browser, so I'm closing this issue. We can keep the bdi tags.