search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.5k stars 260 forks source link

[Dialog]: Add "busy" property #9439

Open lenafi5cher opened 2 months ago

lenafi5cher commented 2 months ago

Is your feature request related to a problem?

Wen loading data inside a dialog, we would like to display a busy state that stretches over the content area, but not the header and footer to ensure actions such as pressing a "close"-button are still possible. The obvious step to achieve this would be to wrap the Busy indicator around all the content elements. However, there is the issue that the content area has a margin that provides spacing to the elements inside the dialog. The Busy Indicator therefore also shows that margin which becomes quite obvious with the new dimmed overlay. Another issue is that the Busy Indicator receives initial focus in this scenario despite not being an actionable element. image

Describe the solution you'd like

Just like with Table and List, I'd like a "busy" property for the Dialog component which applies the busy indicator to the content area. The dimmed overlay should connect to the edges of the dialog while the elements in the content area still maintain the same margins. The displayed busy indicator should not be able to receive focus.

Describe alternatives you've considered

No response

Additional Context

No response

Organization

SAP

Declaration

Lukas742 commented 2 months ago

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

GerganaKremenska commented 2 months ago

Hello @SAP/ui5-webcomponents-topic-rd, take a look of this feature request.

Best Regards, Gergana

dimovpetar commented 1 month ago

Hello @lenafi5cher ,

The first issue will be investigated as bug. Busy indicator could be made to cover dialog's padding. I am curious about the second one - according to the screen reader specification, the busy element must remain focusable, but not actionable. Why would you like it to be not focusable?

Best regards, Petar

lenafi5cher commented 1 week ago

Hi @dimovpetar, Sorry, I missed your comment. Regarding your question, why I would like the busy indicator not to be focusable: I personally couldn't find any specification that the busy indicator should be able to receive focus. From my understanding only elements that can receive an action such as buttons, checkboxes, input fields, etc. should be able to receive focus. However, if you have any specification that outlines that the busy indicator should receive initial focus in this situation, my comment can be disregarded. If possible I would appreciate it if you could tell me where to find the specification so I can bookmark it for later reference. :)