SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.5k stars 258 forks source link

[DynamicSideContent]: [Problem when used with Wizard] #9462

Closed DamyanKolev closed 3 weeks ago

DamyanKolev commented 1 month ago

Describe the bug

DynamicSideContent does not work properly when it is a child component of the Wizard, the problem is that side content it always sits below the main content regardless of the resolution.

Isolated Example

https://stackblitz.com/edit/github-6r86cw?file=src%2FApp.tsx

Reproduction steps

No response

Expected Behaviour

Expected_Behaviour

Screenshots or Videos

No response

UI5 Web Components for React Version

1.29.3

UI5 Web Components Version

1.24.5

Browser

Chrome, Edge

Operating System

Windows

Additional Context

No response

Relevant log output

No response

Organization

No response

Declaration

Lukas742 commented 1 month ago

Hi @DamyanKolev

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.


Hi colleagues,

here you can find an example showing the described issue using ui5-webcomponents without our wrapper or React: https://stackblitz.com/edit/github-fcfk3z?file=index.html,main.js

TeodorTaushanov commented 1 month ago

Hi @SAP/ui5-webcomponents-topic-rl, can you check this issue?

MapTo0 commented 1 month ago

Hello Colleagues,

Could you please change this getter

You need to call getBoundingClientRect().width instead of clientWidth.