SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.56k stars 267 forks source link

[Table]: row aria label not using gridcell content #9473

Closed ee92 closed 2 months ago

ee92 commented 4 months ago

Bug Description

the aria label of each row does not behave as expected

Affected Component

Table, TableRow, TableCell

Expected Behaviour

expect the gridcell contents to be used for the row label

(gridcell content is correct, row label is incorrect)

image

Isolated Example

https://sap.github.io/ui5-webcomponents/v1/play/#eyJpbmRleC5odG1sIjp7Im5hbWUiOiJpbmRleC5odG1sIiwiY29udGVudCI6IjwhLS0gcGxheWdyb3VuZC1mb2xkIC0tPlxuPCFET0NUWVBFIGh0bWw-XG48aHRtbCBsYW5nPVwiZW5cIj5cblxuXG48aGVhZD5cbiAgICBcbiAgICA8c3R5bGU-XG4gICAgICAqOm5vdCg6ZGVmaW5lZCkge1xuICAgICAgICBkaXNwbGF5OiBub25lO1xuICAgICAgfVxuICAgIDwvc3R5bGU-XG5cbiAgICBcbiAgICA8c3R5bGU-XG4gICAgICAqOm5vdCg6ZGVmaW5lZCkge1xuICAgICAgICBkaXNwbGF5OiBub25lO1xuICAgICAgfVxuICAgIDwvc3R5bGU-XG5cbiAgICA8bWV0YSBjaGFyc2V0PVwiVVRGLThcIj5cbiAgICA8bWV0YSBuYW1lPVwidmlld3BvcnRcIiBjb250ZW50PVwid2lkdGg9ZGV2aWNlLXdpZHRoLCBpbml0aWFsLXNjYWxlPTEuMFwiPlxuICAgIDx0aXRsZT5TYW1wbGU8L3RpdGxlPlxuPC9oZWFkPlxuPGJvZHkgc3R5bGU9XCJiYWNrZ3JvdW5kLWNvbG9yOiB2YXIoLS1zYXBCYWNrZ3JvdW5kQ29sb3IpO1wiPlxuPCEtLSBwbGF5Z3JvdW5kLWZvbGQtZW5kIC0tPlxuXG48dWk1LXRhYmxlPlxuXG4gICAgPHVpNS10YWJsZS1jb2x1bW4gc2xvdD1cImNvbHVtbnNcIj5cbiAgICAgICAgPHNwYW4-c3Bhbjwvc3Bhbj5cbiAgICA8L3VpNS10YWJsZS1jb2x1bW4-XG4gICAgPHVpNS10YWJsZS1jb2x1bW4gc2xvdD1cImNvbHVtbnNcIj5cbiAgICAgICAgPHNwYW4-dGV4dDwvc3Bhbj5cbiAgICA8L3VpNS10YWJsZS1jb2x1bW4-XG4gICAgPHVpNS10YWJsZS1jb2x1bW4gc2xvdD1cImNvbHVtbnNcIj5cbiAgICAgICAgPHNwYW4-cmF0aW5nPC9zcGFuPlxuICAgIDwvdWk1LXRhYmxlLWNvbHVtbj5cbiAgICA8dWk1LXRhYmxlLWNvbHVtbiBzbG90PVwiY29sdW1uc1wiPlxuICAgICAgICA8c3Bhbj5idXR0b248L3NwYW4-XG4gICAgPC91aTUtdGFibGUtY29sdW1uPlxuXG4gICAgPHVpNS10YWJsZS1yb3c-XG4gICAgICAgIDx1aTUtdGFibGUtY2VsbD5cbiAgICAgICAgICAgIDxzcGFuPklOX1NQQU48L3NwYW4-XG4gICAgICAgIDwvdWk1LXRhYmxlLWNlbGw-XG4gICAgICAgIDx1aTUtdGFibGUtY2VsbD5cbiAgICAgICAgICAgIFBMQUlOX1RFWFRcbiAgICAgICAgPC91aTUtdGFibGUtY2VsbD5cbiAgICAgICAgPHVpNS10YWJsZS1jZWxsPlxuICAgICAgICAgICAgPHVpNS1yYXRpbmctaW5kaWNhdG9yIG1heD1cIjVcIiB2YWx1ZT1cIjNcIiBhY2Nlc3NpYmxlLW5hbWU9XCJSQVRJTkdcIi8-XG4gICAgICAgIDwvdWk1LXRhYmxlLWNlbGw-XG4gICAgICAgIDx1aTUtdGFibGUtY2VsbD5cbiAgICAgICAgICAgIDx1aTUtYnV0dG9uIGljb249XCJoZWFydFwiIGFjY2Vzc2libGUtbmFtZT1cIklDT05fQlVUVE9OXCI-PC91aTUtYnV0dG9uPlxuICAgICAgICA8L3VpNS10YWJsZS1jZWxsPlxuICAgIDwvdWk1LXRhYmxlLXJvdz5cblxuPC91aTUtdGFibGU-XG48IS0tIHBsYXlncm91bmQtZm9sZCAtLT5cbiAgICA8c2NyaXB0IHR5cGU9XCJtb2R1bGVcIiBzcmM9XCJtYWluLmpzXCI-PC9zY3JpcHQ-XG48L2JvZHk-XG48L2h0bWw-XG48IS0tIHBsYXlncm91bmQtZm9sZC1lbmQgLS0-XG5cbiJ9LCJtYWluLmpzIjp7Im5hbWUiOiJtYWluLmpzIiwiY29udGVudCI6Ii8qIHBsYXlncm91bmQtaGlkZSAqL1xuaW1wb3J0IFwiLi9wbGF5Z3JvdW5kLXN1cHBvcnQuanNcIjtcbi8qIHBsYXlncm91bmQtaGlkZS1lbmQgKi9cbmltcG9ydCBcIkB1aTUvd2ViY29tcG9uZW50cy9kaXN0L1RhYmxlLmpzXCI7XG5pbXBvcnQgXCJAdWk1L3dlYmNvbXBvbmVudHMvZGlzdC9UYWJsZVJvdy5qc1wiO1xuaW1wb3J0IFwiQHVpNS93ZWJjb21wb25lbnRzL2Rpc3QvVGFibGVDb2x1bW4uanNcIjtcbmltcG9ydCBcIkB1aTUvd2ViY29tcG9uZW50cy9kaXN0L1RhYmxlQ2VsbC5qc1wiO1xuaW1wb3J0IFwiQHVpNS93ZWJjb21wb25lbnRzL2Rpc3QvQnV0dG9uLmpzXCI7XG5pbXBvcnQgXCJAdWk1L3dlYmNvbXBvbmVudHMvZGlzdC9SYXRpbmdJbmRpY2F0b3IuanNcIjsifX0

Steps to Reproduce

  1. go to example and check the aria-label of the table row

Log Output, Stack Trace or Screenshots

No response

Priority

Medium

UI5 Web Components Version

1.24.6

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

SuccessFactors

Declaration

TeodorTaushanov commented 4 months ago

Hi @SAP/ui5-webcomponents-topic-core, can you check this issue?

ilhan007 commented 3 months ago

Hi @ee92

could you also test with the newly developed Table, it's the same columns and content, but using the Table from version 2.

Sooner or later the the v2 Table will remain the one and main Table offering so it will be good to fix such things upfront and your feedback will be very helpful to polish it.

github-actions[bot] commented 2 months ago

Hello, everyone! The issue has been inactive for 21 days. If there are still questions or comments, please feel free to continue the discussion. Inactive issues will be closed after 7 days!

github-actions[bot] commented 2 months ago

Hello, everyone! The issue has been inactive for 28 days, so I am closing the issue.