search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.5k stars 258 forks source link

[Table]: [the table. In High Contrast Black and High Contrast White theme table borders are getting overlapped.] #9526

Closed jadhavarjun closed 6 days ago

jadhavarjun commented 1 month ago

Describe the bug

the table. In High contrast black and white theme table borders within ‘Create’ dialog are getting overlapped. I have attached my application screenshot here where I am getting issue and also providing story book link where you can check the issue.

StoryBook Link: https://sap.github.io/ui5-webcomponents-react/?path=/story/data-display-table--default&globals=theme:sap_horizon_hcb

Steps

  1. click on the given storybook link.
  2. after opening you can click on header rows. here you can see selected in dotted border and it's overlapping already present horizontal line image

I have attached application screenshot below where I am getting issue for your better understanding. ### High contrast black theme image

### High contrast white theme image

Note: The above reported Issue persists for all such UI throughout the application. Hence it should be corrected for all the occurrences.

Isolated Example

No response

Reproduction steps

1. 2. 3. ...

Expected Behaviour

In every theme UIs should not get truncated or overlapped with each other.

Screenshots or Videos

No response

UI5 Web Components for React Version

^1.16.3

UI5 Web Components Version

^1.14.0

Browser

Chrome

Operating System

Windows

Additional Context

No response

Relevant log output

No response

Organization

No response

Declaration

Lukas742 commented 1 month ago

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

tsanislavgatev commented 1 month ago

Hi colleagues,

Can you take a look at the issue?

Best Regards, Tsanislav

jadhavarjun commented 1 month ago

Hi @Lukas742, @tsanislavgatev,

I haven't got any response from last 2 weeks. When can I expect a resolution for this issue? please.

jadhavarjun commented 3 weeks ago

HI @Lukas742 ,

When can I expect a resolution for this issue? please let me know.

jadhavarjun commented 2 weeks ago

Hi @Lukas742, Does anyone working on this issue? Can I know the status?

Lukas742 commented 2 weeks ago

Hi @jadhavarjun

I'm not part of the UI5 Web Components team, so I'm not sure.

@tsanislavgatev @ilhan007 could you please help out here?

nnaydenow commented 2 weeks ago

Hi @jadhavarjun,

We are investigating the issue and the issue might require design specification alignment. I've addressed the issue and I'll ping ASAP when we have update.

jadhavarjun commented 6 days ago

Hi @nnaydenow ,

It's looks like you've closed the issue, so I assume it's been resolved. Could you please let me know when the solution will be released and which version update, we need to install which version to see the changes?

nnaydenow commented 6 days ago

Hi,

The issue was resolved in the current nightly version and it will be available with 2.2.0. I've noticed that you are using version one so with https://github.com/SAP/ui5-webcomponents/pull/9752 it will be available with next patch of 1.24.

nnaydenow commented 6 days ago

Hi @jadhavarjun,

The fix could be tested here for version 2: https://sap.github.io/ui5-webcomponents/nightly/packages/compat/test/pages/Table.html?sap-ui-theme=sap_horizon_hcb

Same fix will be applied for version 1.24.x