search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.5k stars 260 forks source link

[FlexibleColumnLayout]: missing import for icon "vertical-grip" #9534

Open camelCaseChris opened 1 month ago

camelCaseChris commented 1 month ago

Bug Description

The FlexibleColumnLayout uses icon vertical-grip but does not import it. The result are several console errors and the icon is missing.

You can reproduce this in the basic sample of the component documention. Open https://sap.github.io/ui5-webcomponents/components/fiori/FlexibleColumnLayout/#basic-sample and open the console. You will see errors like "No loader registered for the SAP-icons-v5 icons collection. Probably you forgot to import the "AllIcons.js" module for the respective package." Also, when you select a supplier from the list so that the second column expands, you will see that the icon is missing in the column separator.

(PS: it seems strange that the error suggests using the AllIcons.js import. Is importing individual icons not the more usual use-case?)

Affected Component

FlexibleColumnLayout

Expected Behaviour

A component should import all icons it uses.

Isolated Example

See bug description.

Steps to Reproduce

See bug description.

Log Output, Stack Trace or Screenshots

No response

Priority

Medium

UI5 Web Components Version

2.0.1

Browser

Chrome, Firefox

Operating System

Win11

Additional Context

No response

Organization

No response

Declaration

kgogov commented 1 month ago

Hello @camelCaseChris,

Thank you for sharing this finding. I am forwarding this ticket to the responsible team, who will look into it and assist.

@SAP/ui5-webcomponents-topic-p, could you please look into this?

Regards, Konstantin Gogov UI5 Web Components GitHub Dispatcher

kineticjs commented 1 month ago

Hi colleagues,

This issue was recently fixed with https://github.com/SAP/ui5-webcomponents/commit/1be8d6c094827aeedcc6742a6aae81ce6cd2d966

kineticjs commented 1 month ago

@kgogov pointed out offline that despite that the icon is now visualised (as we see from the nightly version: https://sap.github.io/ui5-webcomponents/nightly/components/fiori/FlexibleColumnLayout/ ) the additional issue with the console error is still there, so we will take this for further inspection.