search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.51k stars 262 forks source link

[SF_ACC][ui5-wizard]: disabled wizard step has keyboard focus #9571

Closed GongRichard closed 2 weeks ago

GongRichard commented 1 month ago

Bug Description

disabled wizard step has keyboard focus

Affected Component

ui5-wizard

Expected Behaviour

disabled wizard step shouldn't have keyboard focus

Isolated Example

No response

Steps to Reproduce

  1. open Wizard Play Ground
  2. click open dialog button
  3. it will focus on step 1 and then click right arrow key, it will focus on step 2 which is disabled Expected: Disabled wizard steps need not be part of keyboard navigation. You can check ui5 example, it works correctly. https://sapui5.hana.ondemand.com/#/entity/sap.m.Wizard/sample/sap.m.sample.WizardSingleStep

Log Output, Stack Trace or Screenshots

image

Priority

Medium

UI5 Web Components Version

1.24.x

Browser

Chrome, Edge, Firefox, Safari

Operating System

No response

Additional Context

No response

Organization

SAP SuccessFactors

Declaration

ivoplashkov commented 1 month ago

Hello colleagues,

The issue has been fixed with https://github.com/SAP/ui5-webcomponents/pull/9459 in version 2.0. I tried to cherry-pick the fix in 1.24 but it didn't work out of the box. Could you please check?

Regards, Ivaylo

GongRichard commented 1 month ago

Hi @ivoplashkov , This palygroud shoud be version 2.0.1 Wizard Play Ground, it still can be reproduced.

MapTo0 commented 1 month ago

Hey @GongRichard

The issue is fixed in 2.1.0-rc.2, not yet release in 2.0.x you can check it by setting the version to "nightly" in the playground. Do you need the fix in 1.24?

Best Regards! Martin

GongRichard commented 1 month ago

Hi @MapTo0 , Yes, please downport the fix to the 1.24.x. Thanks, Richard