Closed katapp closed 2 months ago
dimovpetar
commented
2 months ago Hello @katapp ,
When you reach any upload collection item with delete button, you can go further with the Tab key, or directly use Delete key. Have you tried it?
Here is a working example.
Best regards, Petar
katapp
commented
2 months ago In your provided example it works. But here it doesn't work: https://sap.github.io/ui5-webcomponents-react/?path=/docs/inputs-uploadcollection--docs#simulate-upload What is the difference?
dimovpetar
commented
2 months ago Hello @katapp ,
The sample you are sending is in different project - UI5 Web Components for React. The upload collection which you are using is a React wrapper over the ui5-upload-collection, which is located in this repository. Most likely the issue comes from that UI5 Web Components for React are using ui5-webcomponents 1.24. So would you like to see this issue fixed in 1.24?
In the future please open issues for React components in their repository.
Best regards, Petar
Lukas742
commented
2 months ago Hi @dimovpetar
the agreement is that issues that only affect ui5-webcomponents should also be opened in the ui5-webcomponents repo, as we (ui5-webcomponents-react) can only forward the issue in almost all cases anyway. If something is not clear because of our wrapper, we are of course happy to offer support, you can simply tag @MarcusNotheis or me and we will look into it.
Hi @katapp
please always use the provided GitHub template when creating issues. This helps avoid confusion and ensures that important details, such as the version you're using, are clearly specified.
katapp
commented
2 months ago HI @dimovpetar could you send me the link to the react component repository for the future? And yes sure, it would be great to see it fixed in 1.24. best regards, Kathrin
dimovpetar
commented
2 months ago Hello @SAP/ui5-webcomponents-topic-rd ,
Delete button of ui5-upload-collection-item is not accessible in 1.24. Can be reproduced here. It works fine on the main branch.
Best regards, Petar
katapp
commented
2 months ago Hi @dimovpetar thank you for forwarding. Where would I find the React components in their repository for future issues?
Hi @Lukas742 I'm happy to use a template, but where to find it? I opened this issue via https://sap.github.io/ui5-webcomponents/components/ > Footerlink Report issue https://github.com/SAP/ui5-webcomponents/issues/new and there is no template?
Lukas742
commented
2 months ago Hi @katapp
I apologize for the miscommunication between our teams (ui5-webcomponents and ui5-webcomponents-react). Opening issues for UI5 Web Components — whether they are wrapped by our UI5 Web Components for React wrapper or not — is perfectly fine here. So, you’ve come to the right place with this issue :)
To clear up some confusion about repositories:
ObjectPage, AnalyticalTable or charts). You can find the corresponding repository here: https://github.com/SAP/ui5-webcomponents-reactRegarding the issue templates:
Please always select the most appropriate issue template in this list: https://github.com/SAP/ui5-webcomponents/issues/new/choose You can access the list by pressing the "New issue" button.
In this case, you could've chosen the "bug report" template, as the issue is about a bug.
GerganaKremenska
commented
2 months ago Hello @katapp,
Can you retest the the web comonent for react again. As far as i can see the issue is no longer reproducable, thinking they have updated to UI5 Web Components 2.0.
I have tested and the issue is not available.
Closing the issue, if it persist on your side please open
Hi, in the UploadCollectionItem the Delete-Button is not focusable with the tab key. But it is accessibility standard that each button can be focused.
https://sap.github.io/ui5-webcomponents-react/?path=/docs/inputs-uploadcollection--docs#simulate-upload
is this already known?
BR Kathrin