search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.51k stars 262 forks source link

[SF_ACC][ui5-wizard]: Additional announcement made as 'To activate press spacebar or enter' after Wizard progress bar navigation region ends #9683

Closed GongRichard closed 1 month ago

GongRichard commented 1 month ago

Bug Description

Additional information such as 'To activate press spacebar or enter' is announced after accessing the wizard progress bar navigation region in VPC mode of screen reader.

Affected Component

ui5-wizard

Expected Behaviour

Additional information should not be announced, only the relevant information about the UI should be read out.

Isolated Example

No response

Steps to Reproduce

  1. open demo page
  2. open JAWS and switch to VPC mode (INSERT+Z twice in JAWS)
  3. click open dialog button
  4. The announcement "To activate press ENTER or spacebar" is present before the heading of step 1

Log Output, Stack Trace or Screenshots

image image

In UI5 sample, you will find that this instruction is hidden from screen readers.

image

Priority

Medium

UI5 Web Components Version

1.24.x

Browser

Chrome, Edge

Operating System

No response

Additional Context

No response

Organization

SAP SuccessFactors

Declaration

unazko commented 1 month ago

Hello @GongRichard,

I've checked the text hint in the DOM as described. At my side the same isn't read out though: WizardReadings

Which JAWS version are you testing with? Do you navigate further after opening the wizard through the button?

Best regards, Boyan

GongRichard commented 1 month ago

Hi @unazko , I use JAWS 2024. And also NVDA also can reproduce this issue. image Thanks, Richard

yanaminkova commented 1 month ago

Hello @SAP/ui5-webcomponents-topic-rl ,

Could you please have a look at this issue regarding the ui5-wizard?

Steps to Reproduce:

  1. Open demo page
  2. Open JAWS and switch to VPC mode (INSERT+Z twice in JAWS)
  3. Click open dialog button
  4. The announcement "To activate press ENTER or spacebar" is present before the heading of step 1

Thanks and Best regards, Yana

elenastoyanovaa commented 1 month ago

Hello,

Actually, you are not really testing in VPC mode, since you after you switch to VPC mode you activate a button (which is something you do in JAWS application mode) so JAWS automatically switches modes. You need to switch to VPC mode after you activate the button in order to really test the dialog content in reading mode. For example I did the same steps you described in UI5 in the same sample you provided as reference - the descriptive text you are complaining about is also read out in UI5 even though it has a aria-hidden="true", this is because it is linked via aria-describedby to the navigation area and when you enter it with a focus (because the first element is focused once you open a dialog) + the fact that by pressing the button to open the dialog JAWS switches to application mode as well. I also tried both samples in VPC mode and both of them do not announce this additional message. You can try yourself by:

Nevertheless I think that it is more correct to add aria-hidden="true" so I will improve this with https://github.com/SAP/ui5-webcomponents/pull/9738 ,but this won't make any changes in the speech output, as it is correct.

Kind Regards, Elena