search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.5k stars 260 forks source link

[SF][1.24.4][AvatarGroup][A11y][ASAP][Duplicate accessible names] #9717

Open wilson-xu-sap opened 3 weeks ago

wilson-xu-sap commented 3 weeks ago

Describe the bug

There will be duplicate accessible names when using more than one avatargroups.

image

Isolated Example

No response

Reproduction steps

  1. use more than one AvatarGroup
  2. use screen reader to read it.

  3. ...

Expected Behaviour

There will be no duplicate accessible names.

Maybe A way to pass in aria-label and role is necessary.

Screenshots or Videos

image

UI5 Web Components for React Version

1.28.4

UI5 Web Components Version

1.24.4

Browser

Chrome, Edge

Operating System

No response

Additional Context

No response

Relevant log output

No response

Organization

No response

Declaration

Lukas742 commented 3 weeks ago

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

yanaminkova commented 3 weeks ago

Hello @wilson-xu-sap ,

Thank you for reaching out!

Could you please provide an isolated example by forking this stackblitz, where we can reproduce the issue and examine it.

Kind regards, Yana

wilson-xu-sap commented 3 weeks ago

Hello @wilson-xu-sap ,

Thank you for reaching out!

Could you please provide an isolated example by forking this stackblitz, where we can reproduce the issue and examine it.

Kind regards, Yana

Here we cannot modify the accessible name and role. Please provide a way to modify it.

image

https://sap.github.io/ui5-webcomponents/v1/components/AvatarGroup/#properties

yanaminkova commented 3 weeks ago

Hello @ui5-webcomponents-topic-p,

Could you kindly review the feature request concerning the addition of a custom aria-label to the ui5-avatar-group component?

Thanks and Best regards, Yana

dobrinyonkov commented 2 weeks ago

Hello @wilson-xu-sap,

We see the value of updating the label through an API and will take this into consideration. Could you please clarify the need for changing the role of the avatar group?

Kind Regards, Dobrin

wilson-xu-sap commented 2 weeks ago

Hi @dobrinyonkov If it should be read as button, we can keep it as it is. But I think it is not always button.

image