SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.5k stars 260 forks source link

[Feature Request]: allow setting the overlay programmatically for `BusyIndicator` #9723

Open Lukas742 opened 3 weeks ago

Lukas742 commented 3 weeks ago

Feature Request Description

In UI5WCR we're implementing some complex components like the AnalyticalTable and charts, that are now leveraging the BusyIndicator. Since these components do a lot of layouting themselves, rendering the BusyIndicator in the normal flow of the document proves problematic and would need a lot of tweaking to achieve the desired behavior. The easiest way to avoid this, is positioning the indicator above the elements, so outside of the normal flow. In this case, we don't need to set children, but still want the focus behavior and overlay color of the indicator. Currently we're adding a dummy element as child, but we'd like to avoid that.

https://stackblitz.com/edit/github-s8qe12?file=index.html,main.js,package.json

I'll add an example of our AnalyticalTable once this PR is merged and released.

Edit: Current implementation of the BusyIndicator in our AnalyticalTable: https://stackblitz.com/edit/ui5wcr-at-ar9ih4?file=src%2FApp.tsx

styles:

  height: 100%;
  inset: 0px;
  position: absolute;
  z-index: 1;

Proposed Solution

Add a way to enable the overlay color, even if there are no children rendered inside the component.

Proposed Alternatives

No response

Organization

UI5WCR

Additional Context

No response

Priority

None

Privacy Policy

yanaminkova commented 3 weeks ago

Hello @SAP/ui5-webcomponents-topic-rd,

Could you please review this feature request regarding the ui5-busy-indicator component?

Thanks and Best regards, Yana