search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.5k stars 260 forks source link

MultiComboBox : valueState is not updated when it should be #9736

Closed SimonBernstein closed 2 weeks ago

SimonBernstein commented 3 weeks ago

Describe the bug

I have a MultiComboBox containing two MultiComboBoxItem. I have defined a state so the there is a ValueState.Error and a message when there is no item selected. In some case the value state is not updated correctly when it should be. Seet steps to reproduce and isolated example in stackBlitz.

Isolated Example

https://stackblitz.com/edit/github-52u2mk?file=src%2FApp.tsx

Reproduction steps

1.Open https://stackblitz.com/edit/github-52u2mk?file=src%2FApp.tsx 2.select an element (ID in the combo list) 3.Deselect the ID 4type I in the list and select ID 5 note that there is still a ValueState.Error when there shouldn't be any ...

Expected Behaviour

note that there is still a ValueState.Error when there shouldn't be any

Screenshots or Videos

No response

UI5 Web Components for React Version

"@ui5/webcomponents-react": "~1.29.0",

UI5 Web Components Version

"@ui5/webcomponents": "~1.24.0",

Browser

Chrome

Operating System

No response

Additional Context

No response

Relevant log output

No response

Organization

Common-controls

Declaration

Lukas742 commented 3 weeks ago

Hi @SimonBernstein

I tried to break down the issue to its core. Could you please take a look at this StackBlitz example and let me know if it demonstrates the bug you want to report or if there's something else wrong with the component?

Reproduction steps

  1. Select an item
  2. See that an empty error popover is still visible, although it shouldn't
image

If there's nothing else wrong, I will then forward the issue to the ui5-webcomponents repo, as the component is developed there.

SimonBernstein commented 3 weeks ago

Hi @Lukas742, that's exactly the issue we are encountering! Thanks a lot for the forward to the ui5-webcomponents team

Regards,

Simon

Lukas742 commented 3 weeks ago

@SimonBernstein you're welcome :)

Hi colleagues, please take a look at this issue. You can find an example using only ui5wc without React or our wrapper here: https://stackblitz.com/edit/github-kdkeah?file=index.html,main.js,package.json

Reproduction steps

  1. Select an item
  2. See that an empty error popover is still visible, although it shouldn't
image
yanaminkova commented 3 weeks ago

Hello @SAP/ui5-webcomponents-topic-rl ,

Could you please have a look at this issue regarding the ui5-multi-combobox component?

Reproduction steps:

  1. Open https://stackblitz.com/edit/github-kdkeah?file=index.html,main.js,package.json
  2. Select an item
  3. Note that an empty error popover is still visible

Thanks and Best regards, Yana