search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.5k stars 260 forks source link

[ui5-multi-combobox]: regularly failing test #9778

Closed nnaydenow closed 2 days ago

nnaydenow commented 2 weeks ago

Bug Description

Following test is regularly failing and it set to be skipped to unblock the build. Please check why it's failing and adjust it.

[chrome-headless-shell 128.0.6613.84 linux #0-7] Running: chrome-headless-shell (v128.0.6613.84) on linux [chrome-headless-shell 128.0.6613.84 linux #0-7] Session ID: a2ccc7e1a4b39729722bbb81b7383c25 [chrome-headless-shell 128.0.6613.84 linux #0-7] [chrome-headless-shell 128.0.6613.84 linux #0-7] » /test/specs/MultiComboBox.spec.js [chrome-headless-shell 128.0.6613.84 linux #0-7] MultiComboBox general interaction [chrome-headless-shell 128.0.6613.84 linux #0-7] ARIA attributes [chrome-headless-shell 128.0.6613.84 linux #0-7] ✖ aria-describedby value according to the tokens count [chrome-headless-shell 128.0.6613.84 linux #0-7] [chrome-headless-shell 128.0.6613.84 linux #0-7] 95 passing (2m 25.7s) [chrome-headless-shell 128.0.6613.84 linux #0-7] 1 failing [chrome-headless-shell 128.0.6613.84 linux #0-7] [chrome-headless-shell 128.0.6613.84 linux #0-7] 1) ARIA attributes aria-describedby value according to the tokens count [chrome-headless-shell 128.0.6613.84 linux #0-7] aria-describedby text is correct: expected false to be truthy [chrome-headless-shell 128.0.6613.84 linux #0-7] AssertionError: aria-describedby text is correct: expected false to be truthy [chrome-headless-shell 128.0.6613.84 linux #0-7] at Context. (file:///home/runner/work/ui5-webcomponents/ui5-webcomponents/packages/main/test/specs/MultiComboBox.spec.js:1780:11) [chrome-headless-shell 128.0.6613.84 linux #0-7] at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

Affected Component

No response

Expected Behaviour

No response

Isolated Example

No response

Steps to Reproduce

1. 2. 3. ...

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

nightly

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

elenastoyanovaa commented 2 weeks ago

Hello @SAP/ui5-webcomponents-topic-rl ,

I did not manage to run the test locally in order to deep dive in the issue, but the mentioned test has a history of being unstable: https://github.com/SAP/ui5-webcomponents/issues/8567

I did a fix, but it seems that it fails again: https://github.com/SAP/ui5-webcomponents/pull/8867

Actually the root cause is that the functionality behind the test is not working correctly. We have a reported issue in the queue regarding this: https://github.com/SAP/ui5-webcomponents/issues/8908 I have raised the Prio since it is from May and it is the second time we have reports for unstable tests. Please check the reporter description plus the description from Nayden in issue #8567

As mentioned in the existing issue the same functionality in the MultiInput works correctly and the same test is stable. Ideally if the bug is fixed, we could copy paste the test from the MultiInput and everything should work correctly and reliably.

Kind Regards, Elena