SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.54k stars 265 forks source link

[Input]: [Not reading input type after accessibleName is reading placeholder and placeholder name that is wrong behaviour] #9802

Closed jadhavarjun closed 1 month ago

jadhavarjun commented 2 months ago

Describe the bug

We have input field into the filter column, when we focus on that input field it should read accessibleName and input type for e.g here I am attaching the screenshot that expected behavior we want. expected behavior: Screenshot 2024-08-23 092554 In that above screenshot you can see JAWS reader reading input field accessible name and input type correctly and that works with only input type number and password for other input type for e.g text, string, URL is not working perfectly. Here is I am attaching incorrect screenshot in that screenshot I have highlighted placeholder and placeholder name that in incorrect reading please fix that issue. Incorrect reading screenshot: Screenshot 2024-08-23 091001

Here is storybook link where you can test: https://sap.github.io/ui5-webcomponents-react/v1/?path=/story/inputs-input--default&args=type:URL;accessibleName:arjun;placeholder:arjun

Step:

  1. Open the link and I have already entered accessibleNam="arjun" and placholder="arjun".
  2. you can select input type is number and check with JAWS reader is reading correctly "arjun spin box edit" but when you select input type is text it will read like "arjun edit blank placeholder arjun Type in text." that placeholder arjun is inorrect. 3.Try with another input type and please fix this issue for all the type.

Isolated Example

No response

Reproduction steps

1. 2. 3. ...

Expected Behaviour

No response

Screenshots or Videos

No response

UI5 Web Components for React Version

latest

UI5 Web Components Version

latest

Browser

Chrome

Operating System

WIndows

Additional Context

No response

Relevant log output

No response

Organization

No response

Declaration

Lukas742 commented 2 months ago

Hi @jadhavarjun

in your description you link to the v1 docs of ui5-webcomponents-react, but in the corresponding section you're referring to the latest version which is 2.0.0 (ui5wcr) or 2.1.2 (ui5wc), so please specify which version you're using. Also, please describe what the expected screen reader output should be.

jadhavarjun commented 2 months ago

Hi @Lukas742 ,

Here, I am attaching screenshot of storybook page where I tested the input field with different types https://sap.github.io/ui5-webcomponents-react/v1/?path=/story/inputs-input--default&args=type:URL;accessibleName:arjun;placeholder:arjun if you click on that link you will get to know which version and I teste this scenario.

Version: v1 Screenshot 2024-09-04 112207

Lukas742 commented 2 months ago

Hi @jadhavarjun I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.


Hi Colleagues,

forwarding this issue to you. Here you can find the example @jadhavarjun has provided, just without React or our wrapper: https://stackblitz.com/edit/github-zfuqpa?file=index.html,main.js,package.json

Additionally, I've checked the behavior with VoiceOver, as I don't have access to JAWS, and it behaves the same as with a native input.

kskondov commented 2 months ago

Hello @ui5-webcomponents-topic-rl ,

Can you take a look of issue for incorrect reading for the input component with type text in version 1?

Best Regards, Konstantin

ndeshev commented 1 month ago

Hello @jadhavarjun,

I can not reproduce the issue with JAWS on Windows OS, the type and the accessible name are being announced correctly and without redundant speech output.