SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.54k stars 265 forks source link

【SF】【Table】【A11y】More button lacks descriptive accessible name #9807

Closed tandan0813 closed 3 weeks ago

tandan0813 commented 2 months ago

Is your feature request related to a problem?

Recently, I've received an a11y issue about the accessible name for more button in Table. It will read "More Button" and we can't set the descriptive accessible name for it.

However, the A11y expert expect the similar behavior here. image

Describe the solution you'd like

Support setting accessible-name for more button in Table.

Describe alternatives you've considered

No response

Additional Context

No response

Organization

No response

Declaration

Lukas742 commented 2 months ago

Hi @tandan0813

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

Please also let my colleagues know which version of the Table component you're using and the @ui5/webcomponents version.

tandan0813 commented 2 months ago

Hi, thanks for your reply @Lukas742. The version of @ui5/webcomponents we use: "@ui5/webcomponents": "1.24.0" "@ui5/webcomponents-react": "1.28.4"

kskondov commented 2 months ago

Hello @SAP/ui5-webcomponents-core , Can you please take a look at this issue/feature request for setting accessible-name for more button in Table. Best Regards, Konstantin

simlin commented 3 weeks ago

Seems to be related to compat table only for which a fix was already performed.

For the new table text and subtext are associated with the button and a fix description about the purpose of the button is also available, see https://sap.github.io/ui5-webcomponents/nightly/components/TableGrowing/#growing-with-a-button