search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.57k stars 270 forks source link

[MessageStrip]: Close button tooltip message is not according to design and no accessibleName is present. #9874

Open pankajpandey01 opened 2 months ago

pankajpandey01 commented 2 months ago

Describe the bug

Close button tooltip message is not according to design. Same tooltip is shown for Design - "Information", "Positive", "Negative", "Warning Tooltip: Information Bar Close

There is no accessibleName

Isolated Example

No response

Reproduction steps

  1. Go to https://sap.github.io/ui5-webcomponents-react/v1/?path=/docs/data-display-messagestrip--docs
  2. See close button tooltip of MessageStrip

Expected Behaviour

Tooltip message should be according to design. accessibleName should be present. (It is good to have same accessibleName as tooltip otherwise Screen Reader will read both tooltip and accessibleName which usually will have same meaning in this case)

Screenshots or Videos

No response

UI5 Web Components for React Version

1.29.3

UI5 Web Components Version

1.24.7

Browser

Chrome, Edge, Firefox, Safari

Operating System

No response

Additional Context

No response

Relevant log output

No response

Organization

SuccessFactors

Declaration

MarcusNotheis commented 2 months ago

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

IlianaB commented 2 months ago

Hello @SAP/ui5-webcomponents-topic-rl , this inquiry looks more like a feature request. Please, consider if accessibleName is required here and/or the tooltip message should be different according to the "design" of the MessageStrip - "Information", "Positive", "Negative", "Warning" (currently, it is "Information Bar Close" for all designs).

Regards, Iliana

elenastoyanovaa commented 1 month ago

Hello,

We will enrich the tooltip of the close button according to the spec, but in the specification there is no accessibleName. As these are to different requests I would like to ask you to follow the InnerSource process for design change and request the accessibleName separately. Please keep in mind that a use case should be provided.

In this issue we will process the enrichment of the tooltip - including the design in the tooltip value. We need to double check with the designers if we should add Positive or Success and etc, for the other types of design.

Kind Regards, Elena

hristop commented 1 month ago

P1 BLI was created: FIORITECHP1-31872