search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.56k stars 267 forks source link

[Button | Belize]: Button focus border color is different compared to previous versions #9900

Closed shubhamnazare closed 1 month ago

shubhamnazare commented 1 month ago

Bug Description

Button focus outline is different compared to previous version of UI5WC.

UI5WC 1.14.0 version has white line image

After upgrading to UI5WC 1.24.8 version, it has black line

Affected Component

No response

Expected Behaviour

No response

Isolated Example

https://stackblitz.com/edit/github-jz3rcw?file=index.html

Steps to Reproduce

1. 2. 3. ...

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

1.24.8

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

IlianaB commented 1 month ago

Hello @shubhamnazare , I have just checked the Visual Specification for the Emphasized button on Belize theme and it should indeed have a black dotted border. Seems like it was correctly aligned with the spec now.

Regards, Iliana

shubhamnazare commented 1 month ago

Hi @IlianaB Could you please share the specification?

IlianaB commented 1 month ago

Hello @shubhamnazare , Unfortunately, there is no public visual spec. You can contact me internally. As a reference you can see how OPENUI5 Button is implemented: https://ui5.sap.com//#/entity/sap.m.Button/sample/sap.m.sample.Button (change theme with Settings button above the Sample. You can also edit the Sample to have a Button with type="Emphasized").

Regards, Iliana