SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.51k stars 260 forks source link

[Link/SegmentedButton]: [SF][A11y] Styling and focus issue of Segmented buttons and Link in Windows High Contrast theme #9917

Open Ankitadoshi opened 7 hours ago

Ankitadoshi commented 7 hours ago

Describe the bug

When we apply High contrast theme in windows system using following steps:

  1. Select Start then Settings then Ease of Access then High contrast
  2. Turn on the toggle under Turn on high contrast
  3. Select a theme from the drop-down menu
  4. Select Apply

Then the styling for segmented buttons is not proper. Also when we focus on Link elements, the focus styles are not clearly visible

Isolated Example

https://sap.github.io/ui5-webcomponents-react/v2/?path=/story/data-display-link--default&globals=theme:sap_horizon_dark, https://sap.github.io/ui5-webcomponents-react/v2/?path=/story/inputs-segmentedbutton--default&globals=theme:sap_horizon_dark

Reproduction steps

1.Turn on Windows High contrast theme by following below steps:

  1. Open storybook link for segmented button and observe that the buttons are not styled correctly
  2. Open storybook link for the Link and focus on the link via tab key. Observe that the focus is not clearly visible

Expected Behaviour

In windows HC themes, 1) Styling for the segmented button should be correct 2) Link focus should be clearly visible

Screenshots or Videos

Screenshot 2024-09-20 at 3 14 56 PM Screenshot 2024-09-20 at 3 14 36 PM

UI5 Web Components for React Version

latest

UI5 Web Components Version

latest

Browser

Chrome

Operating System

Windows

Additional Context

No response

Relevant log output

No response

Organization

SF

Declaration

Lukas742 commented 3 hours ago

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

IlianaB commented 2 hours ago

Hello @ui5-webcomponents-topic-b , I am not sure this is a supported scenario, but I am forwarding this ACC issue to you, so that ACC experts can decide.

When using High Contrast Theme on Windows machine with sap_horizon_dark theme SegmentedButton and Link do not have correct styles, including when focused.

To reproduce:

Regards, Iliana