search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.51k stars 263 forks source link

[Dialog]: Change combobox selection will crash app #9957

Open skowrons opened 3 days ago

skowrons commented 3 days ago

Describe the bug

When we use a ComboBox inside a Dialog component it will crash the app after we change the selection again.

Isolated Example

https://stackblitz.com/edit/github-fzbkcn?file=src%2FApp.tsx

Reproduction steps

  1. Open Dialog
  2. Select something without search
  3. Select some other thing
  4. App will crash

Expected Behaviour

App should not crash.

Screenshots or Videos

No response

UI5 Web Components for React Version

2.1.1

UI5 Web Components Version

2.2.0

Browser

Chrome

Operating System

MacOS

Additional Context

No response

Relevant log output

No response

Organization

No response

Declaration

skowrons commented 3 days ago

This error will not surface on Safari.

Screenshot: Bildschirmfoto 2024-09-28 um 15 51 09

Chrome Version: Version 129.0.6668.71 (Offizieller Build) (x86_64) (newest currently)

Lukas742 commented 1 day ago

Hi @skowrons

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

Hi Colleagues,

with plain HTML and JS, I wasn't able to reproduce the exact same error, but still an error is thrown when dynamically adding ComboBoxItems in runtime. So, it probably has the same root cause.

Edit: I've used the wrong tag-name for the ComboBoxItems. I've edited my example and now the app crashes with plain HTML and JS as well.

Example: https://stackblitz.com/edit/github-994pyy-pic3za?file=index.html,main.js,package.json

  1. Open Dialog
  2. Select something without search
  3. Select some other thing
  4. App will crash