SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.57k stars 267 forks source link

Tab Component: a11y : aria-expanded attribute is missing to indicate where a control is collapsed or expanded. #9958

Closed yoganjan closed 1 month ago

yoganjan commented 1 month ago

Describe the bug

For the tab component , when sub tabs are available, the aria-expanded attribute is missing to indicate where a control is collapsed or expanded. The attribute value should change to true when a control is expanded and be set to false when it is collapsed. The attribute is required, whether it is true or false,

Isolated Example

https://sap.github.io/ui5-webcomponents-react/v2/?path=/story/layouts-floorplans-tabcontainer--with-nested-tabs

Reproduction steps

  1. Navigate to https://sap.github.io/ui5-webcomponents-react/v2/?path=/story/layouts-floorplans-tabcontainer--with-nested-tabs
  2. Observe that the Tab component has sub tabs
  3. When the sub tabs are opened or closed , aria-expanded attribute is missing

Expected Behaviour

The aria-expanded attribute value should change to true when a control is expanded and be set to false when it is collapsed.

Screenshots or Videos

No response

UI5 Web Components for React Version

v2

UI5 Web Components Version

v2

Browser

Chrome

Operating System

Mac

Additional Context

No response

Relevant log output

No response

Organization

SAp

Declaration

Lukas742 commented 1 month ago

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

LidiyaGeorgieva commented 1 month ago

Hello @yoganjan ,

The tabs are not collapsible/expandable. They just open a menu with subtabs, which is announced. I see no issue here.

Best Regards, Lidiya