SAP / webide-client-tools

Tools & Flows for SAP Web IDE Client Side Features. https://sap.github.io/webide-client-tools/web/site/
Apache License 2.0
17 stars 13 forks source link

chore: package dependencies upgraded #166

Closed alex-gilin closed 2 years ago

bd82 commented 2 years ago

There are too many changes in this PR. some of which may break the project at runtime (unlikely that 100% of functionality is tested in an automated manner...)

  1. Prettier version change should be done in a seprate PR as it touches dozens of file and makes reviewing the PR diffcult.
  2. Changing the TypeDoc output folder should be done ina separate PR as once again it touches many files.
    • do the github pages settings need be adjusted after you moved the generated sources?
    • did you test the generated webpage locally?
  3. minor/patch version updates should be handled differently than major version changes.
    • Also dev-deps vs deps changes may need different handling.
  4. updating CI images should likely be done separatly (if we need to revert it).
  5. Updating our peerDeps should likely be considered a breaking change.

In regards to point 3 above:

In regards to our next version number:

bd82 commented 2 years ago

You can merge seprate PRs for:

without waiting for sync review (to reduce ping-pong...). I will review them async. Naturally you should test required things post-merge, e.g:

alex-gilin commented 2 years ago

separated into 4 different PRs