Closed tal-sapan closed 6 years ago
There were no related issues for these changes
Should it be a minor or patch version?
subjective, I would go with minor because rearranging docs is more than a patch
I can't release from my computer because the tests fail on Windows. Could you do it?
Yes, but the root problem of running on windows should still be resolved and it would be difficult for me to resolve it without a windows machine...
release job is running here: https://circleci.com/gh/SAP/webide-client-tools/276
Thanks. It should definitely be resolved, but it shouldn't postpone a release. We should fix this ASAP. (And also maybe setup a manually-triggered job to do it instead of running it manually from a user's computer, is this possible?)
The release to npm does not run from a developer's computer. The push of the new tag does run from a developer computer.
For safety reasons the full voter is executed locally before a new tag is pushed. This voter flow is also run centrally before npm publish is executed.
I think the main thing to resolve this is enable an additional voter running under windows This is possible using https://www.appveyor.com/ They probably have free offering for OSS projects.
In the future you can consider adding links to the change log example: https://github.com/SAP/chevrotain/blob/master/docs/changes/CHANGELOG.md