search

SAPikachu / flash3kyuu_deband

A deband library and filter for avisynth/vapoursynth
http://www.nmm-hd.org/newbbs/viewtopic.php?f=7&t=239
GNU General Public License v3.0
50 stars 12 forks source link

Documentation improvement #7

Closed theChaosCoder closed 8 years ago

theChaosCoder commented 8 years ago

http://f3kdb.readthedocs.io/en/latest/presets.html

Wouldn't it be better if this:

y=48/cb=48/cr=48/grainy=48/grainc=48

becomes like this:

y=48, cb=48, cr=48, grainy=48, grainc=48

so one can copy and paste it more easily.

SAPikachu commented 8 years ago

Well, this is not meant to be copied, as we can easily override preset parameters by using both preset and separate parameters. Did I miss anything?

theChaosCoder commented 8 years ago

Then I'm throwing in: better readability :)

I tried to used f3kdb with lumaDBL(), but couldn't get the presets parameter to work. """medium""" also didn't work. Hence the copy & paste...

LumaDBL(dither="f3kdb(range=20,preset="""medium""", keep_tv_range=true ")

SAPikachu commented 8 years ago

preset is only supported in latest git build (or 2.0 alpha/beta versions), maybe you need to update the plugin?

theChaosCoder commented 8 years ago

I'm using 2.0 pre. It's more of a LumaDBL issue (or just wrong avisynth syntax) . A plain f3kdb(range=20, preset="medium", keep_tv_range=true) works of course.

SAPikachu commented 8 years ago

Oh OK, I guess it's syntax issue then. try:

LumaDBL(dither="""f3kdb(range=20,preset="medium", keep_tv_range=true)""")
theChaosCoder commented 8 years ago

Omg, of course. Stupid me!! It works now, thx.