search

SASlions1 / jmm

Automatically exported from code.google.com/p/jmm
0 stars 0 forks source link

Automatically mark Files as watched is not working correctly. #402

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Set the percentage to any value. (I tested this with 75%, 90% and 95%)
2. Play a file that has not yet been opened with MPC and therefore has no entry 
in the .ini-file.

What is the expected output? What do you see instead?
The file is then immediatly marked as watched even though it shouldn't. Most 
likely upon receiving an entry in the .ini-file.

What version of the product are you using? On what operating system?
I am using JMM Desktop version 3.1.28.0 and MPC-HC lite version 1.6.6.6659.

Please provide any additional information below.
If you unmark this file and the entry in the .ini is still there, rewatching 
the episode "fixes" the problem because the mark-percentage is working 
correctly then.

Original issue reported on code.google.com by kav...@googlemail.com on 8 Feb 2013 at 1:31

GoogleCodeExporter commented 8 years ago 
Are you using the play button in the JMM both times?

Original comment by imperia...@gmail.com on 13 Feb 2013 at 12:47

GoogleCodeExporter commented 8 years ago 
I just tested it again and this is still an issue. And yes I clicked the play 
button.

Original comment by kav...@googlemail.com on 13 Feb 2013 at 12:52

GoogleCodeExporter commented 8 years ago 
As I can't edit my comment above, here is a small update regarding this issue:

After looking at the code, I found out that a file is marked as watched if
a) File-Pos in the .ini = 0
b) File-Pos is above the percentage.

These obviously aren't any news to you, but according to this I did a little 
experiment:
1. Start a file and close MPC as fast a possible.
2. Look at the .ini and observe the corresponding file-position.

As I closed the window right before the episode would start (and therefore the 
MPC-logo was still visible), the file-position of that file was 0.
According to this I'm guessing that your filewatcher is "too fast" and 
therefore reads the 0 and marks the file as watched.

I hope this helps you in fixing this.

Original comment by kav...@googlemail.com on 13 Feb 2013 at 4:49

GoogleCodeExporter commented 8 years ago 
https://github.com/japanesemediamanager/jmmclient/issues/45

Original comment by werndly...@gmail.com on 19 Aug 2014 at 7:49