search

SAkbari93 / PCV-method

Localized PhysicoChemical Vector-based method for Protein Sequence Comparison and Clustering
0 stars 0 forks source link

Euclidean distance issue #1

Open liaotinhow opened 1 year ago

liaotinhow commented 1 year ago

Hi SAkbari93, I had read your paper, and I had some question about your coding. In paper's euclidean distance, your formula of ED sum each elements' square values' and root the sum value to get the ED, however, your code in line 129 to line 132 seems like only get the maximum value of each elements' absolute value. I wonder are these two formula the same? Thanks, best regard, Tom Liao

SAkbari93 commented 1 year ago

Dear Tom Liao,

Thank you for bringing this to our attention. You are correct in your observation that the formula used in the code (line 129 to line 132) is not the Euclidean distance formula mentioned in our paper. This mistake occurred because we had tested various distance metrics like Chebyshev distance and Manhattan distance, and the code was not updated to reflect the final choice of Euclidean distance as the best metric.

We apologize for any confusion this may have caused, and we will update the code accordingly. Once again, thank you for pointing this out and bringing it to our attention.

Best regards, Saeedeh Akbari

liaotinhow commented 1 year ago

Thanks for your update!