search

SAmeis / pascalio

Input/Output library for Raspberry Pi or any other Linux based microcontroller
Other
30 stars 9 forks source link

pascalio breaks class properties convention #6

Closed antispam88 closed 5 years ago

antispam88 commented 5 years ago

Hi,

you wrote to comment your package on http://www.lazarusforum.de, but there still exists the issue regarding registration (http://www.lazarusforum.de/viewtopic.php?f=14&t=11832).

So I have to make my comment hear: Your code breaks the class properties convention (https://www.freepascal.org/docs-html/3.0.0/ref/refse39.html). In FPC 3.0.4 your code is wrongly accepted, but in all version 3.1+ it isn't allowed anymore (see http://forum.lazarus-ide.org/index.php/topic,42265.msg306140.html#msg306140).

Best regards, antispam88

SAmeis commented 5 years ago

The issue is fixed with commit 231cff0d272e134c224353c2f7de481ab4cfa9fc. This converts most class properties to simple instance properties because I didn't find an solution for having this information in class properties while defining the actual values in descendent classes.

antispam88 commented 5 years ago

Thank you for your quick adjustments.