SAnsell / CombLayer

MCNP(X) project builder using C++
GNU General Public License v3.0
14 stars 13 forks source link

Zaid #91

Closed kbat closed 11 months ago

kbat commented 6 years ago

I modified the Zaid class for the low energy neutron cross section assignment in FLUKA:

I believe it's important to understand and merge these changes into the master branch before merging with flukaFix one day in the future.

SAnsell commented 6 years ago

Thanks that is REALLY appreciated!!

On 30 January 2018 at 14:19, Konstantin Batkov notifications@github.com wrote:

I modified the Zaid class for the low energy neutron cross section assignment in FLUKA:

  • operator < is overloaded since I need to make a set of Zaid objects;
  • method getZaid() added since I need to use Zaid in a couple of different places;
  • method getFlukaName() added (it's ZZAAA.abX without the dot symbol in order to reduce the name length to 8 characters - maximum allowed by FLUKA).

I believe it's important to understand and merge these changes into the master branch before merging with flukaFix one day in the future.

You can view, comment on, or merge this pull request online at:

https://github.com/SAnsell/CombLayer/pull/91 Commit Summary

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/SAnsell/CombLayer/pull/91, or mute the thread https://github.com/notifications/unsubscribe-auth/AAZOQ74p38VzgOxfjSltB4RFNR7PLhfiks5tPyT-gaJpZM4RyZrd .

kbat commented 6 years ago

It's actually annoying that travis builds with g++ always fail. On my machine both g++ and clang compilers work fine with all models. Something should be wrong in travis.xml - we have to fix this one day.