Closed kbat closed 11 months ago
Thanks that is REALLY appreciated!!
On 30 January 2018 at 14:19, Konstantin Batkov notifications@github.com wrote:
I modified the Zaid class for the low energy neutron cross section assignment in FLUKA:
- operator < is overloaded since I need to make a set of Zaid objects;
- method getZaid() added since I need to use Zaid in a couple of different places;
- method getFlukaName() added (it's ZZAAA.abX without the dot symbol in order to reduce the name length to 8 characters - maximum allowed by FLUKA).
I believe it's important to understand and merge these changes into the master branch before merging with flukaFix one day in the future.
You can view, comment on, or merge this pull request online at:
https://github.com/SAnsell/CombLayer/pull/91 Commit Summary
- Bugfix: in Cylinder::writeFLUKA: wrong order of YCC coordinates (thanks to Rodion)
- Merge branch 'master' of http://github.com/SAnsell/CombLayer
- Merge branch 'master' of http://github.com/SAnsell/CombLayer
- getZaid,getFlukaName methods added and the '<' operator overloaded
File Changes
- M System/monte/Zaid.cxx https://github.com/SAnsell/CombLayer/pull/91/files#diff-0 (65)
- M System/monteInc/Zaid.h https://github.com/SAnsell/CombLayer/pull/91/files#diff-1 (9)
Patch Links:
- https://github.com/SAnsell/CombLayer/pull/91.patch
- https://github.com/SAnsell/CombLayer/pull/91.diff
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/SAnsell/CombLayer/pull/91, or mute the thread https://github.com/notifications/unsubscribe-auth/AAZOQ74p38VzgOxfjSltB4RFNR7PLhfiks5tPyT-gaJpZM4RyZrd .
It's actually annoying that travis builds with g++ always fail. On my machine both g++ and clang compilers work fine with all models. Something should be wrong in travis.xml - we have to fix this one day.
I modified the
Zaid
class for the low energy neutron cross section assignment in FLUKA:<
is overloaded since I need to make a set of theZaid
objects;getZaid()
added since I need to use Zaid in a couple of different places;getFlukaName()
added (it's ZZAAA.abX without the dot symbol in order to reduce the name length to 8 characters - maximum allowed by FLUKA).I believe it's important to understand and merge these changes into the
master
branch before merging withflukaFix
one day in the future.